Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scale property on java component #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AllyW
Copy link
Owner

@AllyW AllyW commented Aug 27, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@@ -5,6 +5,10 @@ Release History

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary:

  1. Added support for --min-replicas and --max-replicas parameters to the az containerapp env java-component command.
  2. Introduced a new preview API version 2024-08-02-preview.
  3. Updated methods and classes to handle new replica parameters.
  4. Expanded existing tests to include replica count checks.
  5. Removed obsolete test scenarios and consolidated the Java component-related tests.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

0.3.56
++++++
* 'az containerapp env java-component`: Support --min-replicas and --max-replicas for Java components'

0.3.55
++++++
* 'az containerapp create': Support --registry-identity to use Environment identity for ACR authentication.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Spacing & Punctuation: Change "az containerapp env java-component:to"az containerapp env java-component":`. Adds clarity and punctuation consistency.

Here's the refined section:

0.3.56
+++++++
* "az containerapp env java-component": Support --min-replicas and --max-replicas for Java components

Copy link

Hi @AllyW

Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

@AllyW AllyW force-pushed the main branch 2 times, most recently from 7e9bcf3 to 087db12 Compare August 30, 2024 08:14
@AllyW AllyW added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant